Support building in the Swift toolchain #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The Swift toolchain has an unusual build environment that attempts to check out all package dependencies locally before building begins. To support that flow we need to detect that we're in the toolchain environment and defer to a local checkout accordingly. Modifications: - Added a check for building in the toolchain. Result: Better builds in the toolchain.
Davidde94
approved these changes
Sep 3, 2021
|
FYI you may need apple/swift-nio#1950 (pushing this around the various repos is on my todo list) |
fabianfett
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Swift toolchain has an unusual build environment that attempts to
check out all package dependencies locally before building begins. To
support that flow we need to detect that we're in the toolchain
environment and defer to a local checkout accordingly.
Modifications:
Result:
Better builds in the toolchain.