Parser cleanup (implement shortcut methods, use new parse oneOf) #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #476
Also works to improve the parser errors as mentioned in #483
We now have shortcut functions to the parser library, meaning we don't need
ParserLibrary
to appear every line.Also any instances of calls to
oneOf
where there were 2 or 3 parser functions have been replaced with the new multiple-argument method.Result:
NIOIMAPPerformanceTester
is about 20% fasteroneOf
parser it hits about 30%, but we need to draw the line somewhere.