add flush api to default stdout/stderr logger #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: default logger may not flush the streams on crush, so need to make flushing moe explicit changes: * add a constructor argument to control flushing behaviour, default to "everytime" * add a "flush" method to allow user defined flush timing. this api is now internal but we could expose it if there is a need * add tests
|
solved #86 |
weissi
reviewed
Aug 12, 2019
Tests/LoggingTests/LoggingTest.swift
Outdated
| var fds: [Int32] = [-1, -1] | ||
| fds.withUnsafeMutableBufferPointer { ptr in | ||
| let err = pipe(ptr.baseAddress!) | ||
| assert(err == 0, "pipe: \(err)") |
There was a problem hiding this comment.
because it's in a test case, you can use XCTAssertEqual(0, err)
weissi
requested changes
Aug 12, 2019
|
@weissi addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: default logger may not flush the streams on crush, so need to make flushing moe explicit
changes: