[CI] Migrate to GHA #328
Merged
[CI] Migrate to GHA #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-gha-action
branch
3 times, most recently
from
73089da to
bf0278a
Compare
ktoso
reviewed
Oct 30, 2024
| c.logger.info("Struct2::doSomething") | ||
| self.doSomethingElse(context: c) | ||
| c.logger.debug("Struct2::doSomething::end") | ||
| } | ||
|
|
||
| private func doSomethingElse(context: Context) { | ||
| var c = context | ||
| c.logLevel = .debug // only effects from this point on | ||
| c.logLevel = .debug // only effects from this point on |
There was a problem hiding this comment.
I wonder if there's a way to prevent those, it's somewhat silly to insert a double space... maybe there's a bug for it already?
There was a problem hiding this comment.
Filed an issue about it swiftlang/swift-format#868
ktoso
approved these changes
Oct 30, 2024
|
Ok I think we're green on GH Actions now. I changed all the required checks as well. |
# Motivation We want to modernize our CI. # Modification This PR migrates to GH actions and turns on all the right flags. # Result Modern CI.
FranzBusch
force-pushed
the
fb-gha-action
branch
from
bf0278a to
b20468d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to modernize our CI.
Modification
This PR migrates to GH actions and turns on all the right flags.
Result
Modern CI.