-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Replace standardOutput to standardError #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushi2103
changed the title
feat: Replace standardOutput to standardError
patch: Replace standardOutput to standardError
May 8, 2024
FranzBusch
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thanks for working on this
@swift-server-bot test this please |
ayushi2103
force-pushed
the
Redirect-stdout-to-stderr
branch
2 times, most recently
from
May 9, 2024 01:38
a215ff0
to
c5991d7
Compare
@swift-server-bot test this please |
@swift-server-bot add to allowlist |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jun 27, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [apple/swift-log](https://togithub.com/apple/swift-log) | minor | `from: "1.5.4"` -> `from: "1.6.1"` | --- ### Release Notes <details> <summary>apple/swift-log (apple/swift-log)</summary> ### [`v1.6.1`](https://togithub.com/apple/swift-log/releases/tag/1.6.1): Swift Log 1.6.1 [Compare Source](https://togithub.com/apple/swift-log/compare/1.6.0...1.6.1) ##### SemVer Patch - Disable existential any build setting ([#​312](https://togithub.com/apple/swift-log/issues/312)) ### [`v1.6.0`](https://togithub.com/apple/swift-log/releases/tag/1.6.0) [Compare Source](https://togithub.com/apple/swift-log/compare/1.5.4...1.6.0) #### SemVer Minor - Add Sendability annotations in [https://github.com/apple/swift-log/pull/308](https://togithub.com/apple/swift-log/pull/308) - Fix deprecation warnings around default log implementations on handlers in [https://github.com/apple/swift-log/pull/310](https://togithub.com/apple/swift-log/pull/310) - Drop Swift versions earlier than 5.8 in [https://github.com/apple/swift-log/pull/299](https://togithub.com/apple/swift-log/pull/299) - Implement Copy-On-Write (CoW) behavior for Logger struct by [@​ayushi2103](https://togithub.com/ayushi2103) in [https://github.com/apple/swift-log/pull/297](https://togithub.com/apple/swift-log/pull/297) ##### SemVer Patch - Replace standardOutput to standardError by [@​ayushi2103](https://togithub.com/ayushi2103) in [https://github.com/apple/swift-log/pull/295](https://togithub.com/apple/swift-log/pull/295) - Use Set to spot duplicated log handler warnings in [https://github.com/apple/swift-log/pull/306](https://togithub.com/apple/swift-log/pull/306) - Make protocol usage obvious using any and some keywords in [https://github.com/apple/swift-log/pull/307](https://togithub.com/apple/swift-log/pull/307) - Remove documentation for non-existent arguments by [@​b1ackturtle](https://togithub.com/b1ackturtle) in [https://github.com/apple/swift-log/pull/309](https://togithub.com/apple/swift-log/pull/309) - Remove Docc plugin which is no longer required in [https://github.com/apple/swift-log/pull/311](https://togithub.com/apple/swift-log/pull/311) ##### Other Changes - Remove archived repository in [https://github.com/apple/swift-log/pull/292](https://togithub.com/apple/swift-log/pull/292) - Add CI for Swift 5.10 in [https://github.com/apple/swift-log/pull/287](https://togithub.com/apple/swift-log/pull/287) - Added swift-log-ecs to README.md by [@​rwbutler](https://togithub.com/rwbutler) in [https://github.com/apple/swift-log/pull/298](https://togithub.com/apple/swift-log/pull/298) - Update README.md add shipbook as backend by [@​elishas](https://togithub.com/elishas) in [https://github.com/apple/swift-log/pull/304](https://togithub.com/apple/swift-log/pull/304) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates SwiftLog to direct log messages to the standard error stream (stderr) instead of the standard output stream (stdout).
Motivation:
Standard output is used to print the results from the program to the output, while standard error is used to print the error stream separately. The change also increases readability of logs by keeping them separate from regular output.
Modifications:
I changed the initialization of the _factory property from using
StreamLogHandler.standardOutput
toStreamLogHandler.standardError
Result:
After this change, log messages produced by SwiftLog will be directed to the standard error stream (stderr) instead of the standard output stream (stdout).