-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiscordBM/DiscordLogger to loggers list #257
Conversation
Adds [DiscordBM](https://github.com/MahdiBM/DiscordBM/blob/discord-logger/README.md#discord-logger) to the logger list. The description is: > a Discord package containing a standalone [DiscordLogger library](https://github.com/MahdiBM/DiscordBM/blob/discord-logger/README.md#discord-logger) Please do tell if you think "standalone" is misleading 🤔 I'm just trying to imply that users don't need to depend on the full package just for Discord-logging. Resolves apple#256
Can one of the admins verify this patch? |
11 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
@swift-server-bot test this please |
@swift-server-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ktoso I think we need another round of running tests here 👀 |
Looks good now, thanks! Yep, we'll merge after the checks run |
@swift-server-bot test this please |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [apple/swift-log](https://togithub.com/apple/swift-log) | patch | `from: "1.5.2"` -> `from: "1.5.3"` | --- ### Release Notes <details> <summary>apple/swift-log (apple/swift-log)</summary> ### [`v1.5.3`](https://togithub.com/apple/swift-log/releases/tag/1.5.3) [Compare Source](https://togithub.com/apple/swift-log/compare/1.5.2...1.5.3) ##### What's Changed ##### Cleanups & minor compatibility improvements - Remove leftover 5.0 Package.swift; not supported since 1.5.0 by [@​ktoso](https://togithub.com/ktoso) in [https://github.com/apple/swift-log/pull/259](https://togithub.com/apple/swift-log/pull/259) - Use #if canImport(Darwin) where possible by [@​FranzBusch](https://togithub.com/FranzBusch) in [https://github.com/apple/swift-log/pull/269](https://togithub.com/apple/swift-log/pull/269) - docs: fix typos by [@​FannyGautierr](https://togithub.com/FannyGautierr) in [https://github.com/apple/swift-log/pull/272](https://togithub.com/apple/swift-log/pull/272) ##### Non code changes - Add DiscordBM/DiscordLogger to loggers list by [@​MahdiBM](https://togithub.com/MahdiBM) in [https://github.com/apple/swift-log/pull/257](https://togithub.com/apple/swift-log/pull/257) - Update CI by [@​yim-lee](https://togithub.com/yim-lee) in [https://github.com/apple/swift-log/pull/264](https://togithub.com/apple/swift-log/pull/264) - update code of conduct by [@​tomerd](https://togithub.com/tomerd) in [https://github.com/apple/swift-log/pull/268](https://togithub.com/apple/swift-log/pull/268) - Fix DiscordLogger link by [@​MahdiBM](https://togithub.com/MahdiBM) in [https://github.com/apple/swift-log/pull/266](https://togithub.com/apple/swift-log/pull/266) - add kiliankoe/swift-log-matrix to list of backends by [@​kiliankoe](https://togithub.com/kiliankoe) in [https://github.com/apple/swift-log/pull/263](https://togithub.com/apple/swift-log/pull/263) ##### New Contributors - [@​MahdiBM](https://togithub.com/MahdiBM) made their first contribution in [https://github.com/apple/swift-log/pull/257](https://togithub.com/apple/swift-log/pull/257) - [@​kiliankoe](https://togithub.com/kiliankoe) made their first contribution in [https://github.com/apple/swift-log/pull/263](https://togithub.com/apple/swift-log/pull/263) - [@​FannyGautierr](https://togithub.com/FannyGautierr) made their first contribution in [https://github.com/apple/swift-log/pull/272](https://togithub.com/apple/swift-log/pull/272) **Full Changelog**: apple/swift-log@1.5.2...1.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Motivation:
Add DiscordBM to the loggers list.
The description is:
Please do tell if you think "standalone" seems misleading 🤔 I'm just trying to mention that users don't need to depend on the full package just for Discord-logging.
Resolves #256
Modifications:
Edit README logger-list table.
Result:
More awareness about existence of a Swift package capable of logging to Discord.