[sendable] Sendable conformance checks cause errors on 5.6 but warnings on 5.7 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Aug 12, 2022
|
Note the 5.6 failure, you'll need to make this |
|
Hah right, CI just reminded me of that as well. Painful but it seems that'll help... Thanks for having a look @Lukasa |
ktoso
force-pushed
the
wip-fix-sendable-5.6
branch
3 times, most recently
from
aff3bc8 to
c85114e
Compare
|
Okey, finally got the #if dance right. |
ktoso
force-pushed
the
wip-fix-sendable-5.6
branch
from
c85114e to
2d39d6e
Compare
tomerd
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.6 specific follow up to #218
This would be one way to solve #228 because a missing conformance here is diagnosed as a WARNING on 5.7, but as an ERROR on 5.6.
Other checks are fine on 5.6 AFAICS though.
cc @DougGregor