Improve StdioOutputStream with fwrite (#180) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
8 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
felipejinli
changed the title
|
@swift-server-bot test this please |
weissi
changed the title
weissi
requested changes
Apr 6, 2021
weissi
reviewed
Apr 6, 2021
felipejinli
force-pushed
the
dev
branch
2 times, most recently
from
d5ef3ba to
40b4a73
Compare
|
@weissi Makes sense - I've just incorporated the changes. It should work now! |
|
@swift-server-bot test this please |
|
Sorry @felipejinli , could you run |
|
@weissi done! |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
fputswithfwrite, added test and made spelling correctionsWIP help
(for reference, see the code changes)
On the testing side, I'm currently using
String(validatingUTF8: <unsafe-mutable-pointer>to turn a UnsafeMutablePointer into a String. However, this seems to return a string that stops at the first 0 byte E.g. for a "hello\u{0} world" log it outputs hello only. NB. I have checked thatfwritecorrectly logs a message longer than "hello" through count but testing this is hard. @weissi @ktoso Have you got any suggestions?Motivation:
If a 0 byte is logged,
fputswould not output the content after the 0 byte making it harder to debug (see #180).fwriteuses a count argument so content after 0 byte can be logged.Modifications:
Replaced
fputswith the correct call tofwrite. Added helper internal funccontiguousUTF8(_ string: String) -> String.UTF8View. AddedtestStdioOutputStreamWrite()to test ability to log content after 0 byte.Result:
Improved debugging experience