use #fileID for Swift 5.3+ #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Mar 17, 2021
|
@ktoso I agree that we don't need a major. In theory it could break some backends (which parse the path) but I don't think we really guaranteed that it's the full file path... |
|
@swift-server-bot test this please |
weissi
force-pushed
the
jw-file-id
branch
3 times, most recently
from
43d3599 to
f5d54e4
Compare
Motivation: Right now, we use the full path (`#file`) for the logging as well as for parsing out the module name (which goes into `source` by default). This has two problems: 1. The file names contain the build server's full path, ie. aren't portable across different compiles (and are very long). 2. The module name parsing fails if we log from a file that's not in a directory named just like the module. Modification: Switch `#file` for `#fileID`. This changes a bunch of things: - `source` is always the module name by default (great!) - `file` changes from `/the/full/path/on/disk` to `ModuleName/FileBaseName.swift` (I think better, but it's a change) Result: `source` is more correct, `file` will be different.
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Right now, we use the full path (
#file) for the logging as well as forparsing out the module name (which goes into
sourceby default).This has two problems:
portable across different compiles (and are very long).
directory named just like the module.
Modification:
Switch
#filefor#fileID. This changes a bunch of things:sourceis always the module name by default (great!)filechanges from/the/full/path/on/disktoModuleName/FileBaseName.swift(I think better, but it's a change)Result:
sourceis more correct,filewill be different.