Fix function being dropped on source-less trace

[saulbaro]

Motivation:

When using the recently re-introduced source-less version of trace, the function parameter that reaches the underlying LogHandler is wrong.

Modifications:

Pass the function parameter to trace with source parameter.

Result:

• With these changes, the function parameter that reaches the underlying LogHandler has the correct value.
• Fixes Function parameter dropped in trace #184

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[swift-server-bot]

Can one of the admins verify this patch?

[ktoso]

@swift-server-bot test this please

[ktoso]

Ouch! Thanks for spotting this and the nice report and fix.

I skimmed the other functions, the remaining ones seem fine...

We could cut a quick 1.4.2 if you want, WDYT?

[saulbaro]

Hey @ktoso, thanks to you for reviewing this so quickly :)

Cutting a new release would be great. We've avoided the issue on our end for now by pinning the previous release, but we'd love to revert that back.

Regarding the other functions, this issue was flagged by our unit tests, and it was the only failing one, so I am confident that it is the only one with this issue 🤞

[ktoso]

FYI 1.4.2 released 👍 https://github.com/apple/swift-log/releases/tag/1.4.2

[seanfoltz]

Hi