Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SwiftLogNoOpLogHandler.init() public #146

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Make SwiftLogNoOpLogHandler.init() public #146

merged 1 commit into from
Jul 8, 2020

Conversation

adam-fowler
Copy link
Contributor

I want to cry

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@ktoso
Copy link
Member

ktoso commented Jul 8, 2020

Oh my that's silly 😢 😂

@ktoso ktoso added this to the 1.3.1 milestone Jul 8, 2020
@ktoso ktoso added the 🔨 semver/patch No public API change. label Jul 8, 2020
@ktoso ktoso merged commit 173f567 into apple:master Jul 8, 2020
@ktoso
Copy link
Member

ktoso commented Jul 8, 2020

We can make a 1.3.1 soon, I'd count that as fixup rather than new API after all.

Thanks for the PR @adam-fowler, that was so easy to miss... I didn't think we needed a test for a noop heh but that would have helped spot it I guess -- lesson learnt 🤷‍♂️

@adam-fowler adam-fowler deleted the noop-public-init branch July 8, 2020 13:16
@adam-fowler
Copy link
Contributor Author

@ktoso cheers thanks

@ktoso
Copy link
Member

ktoso commented Jul 15, 2020

Heads up notice, we'll cut a 1.3.1 tomorrow - since there's not much reason not to

@ktoso
Copy link
Member

ktoso commented Jul 16, 2020

Meh, let's call it 1.4.0 since technically we're "adding API".

@ktoso ktoso added 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Jul 16, 2020
@ktoso
Copy link
Member

ktoso commented Jul 16, 2020

And it's out: https://github.com/apple/swift-log/releases/tag/1.4.0

@ktoso ktoso mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-fowler @swift-server-bot @ktoso