Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=doc #82 avoid showcasing internal lock in public docs #144

Merged
merged 1 commit into from
Jul 6, 2020
Merged

=doc #82 avoid showcasing internal lock in public docs #144

merged 1 commit into from
Jul 6, 2020

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Jul 6, 2020

Motivation:

Example in public type was using our internal Lock() so it was not copy paste friendly.

Modifications:

Use foundation's lock in the example.

Result:

@ktoso ktoso requested a review from tomerd July 6, 2020 11:09
@tomerd tomerd added this to the 1.3.0 milestone Jul 6, 2020
@tomerd tomerd added the 🔨 semver/patch No public API change. label Jul 6, 2020
@ktoso ktoso merged commit 57c6bd0 into apple:master Jul 6, 2020
@ktoso ktoso deleted the wip-docs-lockinternal branch July 6, 2020 18:12
@ktoso
Copy link
Member Author

ktoso commented Jul 6, 2020

Thanks @tomerd :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Lock is internal
2 participants
@ktoso @tomerd