Finishing clusterd #1165
Open
Finishing clusterd #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ktoso we can focus on your PR though, can close this one. It's just easier for me to finish it here. |
|
Happy for you to take it over. Fixed up CI so we now just do 5.10+ jobs. |
# Conflicts: # Sources/MultiNodeTestKitRunner/boot+MultiNodeTestKitRunner+Exec.swift
akbashev
commented
Nov 5, 2024
Comment on lines
+494
to
+496
| case `static`(endpoints: Set<Cluster.Endpoint>, subscribe: (@escaping (Result<[Cluster.Endpoint], Error>) -> Void, @escaping (CompletionReason) -> Void) -> CancellationToken?) | ||
| case dynamic(serviceDiscovery: AnyServiceDiscovery, subscribe: (@escaping (Result<[Cluster.Endpoint], Error>) -> Void, @escaping (CompletionReason) -> Void) -> CancellationToken?) | ||
| case clusterDaemon(endpoint: Cluster.Endpoint, initialize: (ClusterSystem) -> Void) |
There was a problem hiding this comment.
Decided to put subscribe and initialize closures here, as otherwise it's quite confusing to have optional values in settings itself.
|
@ktoso I've went through code, cleaned up some stuff, executable is now called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite often people ask "How actors find each other" and clusterd could be a good example to show discoverability.
Again just stealing your code here @ktoso 🙂 Will just try to finish and prettify.