swift-clusterd PoC which serves as seed node #1155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
akbashev
reviewed
Aug 27, 2024
| @Option(help: "The host address to bid the cluster daemon on.") | ||
| var host: String = ClusterDaemon.defaultEndpoint.host | ||
|
|
||
| mutating func run() async throws { |
There was a problem hiding this comment.
Should not be mutating? 🤔
| daemon.system.log.warning("RUNNING ClusterD DEBUG binary, operation is likely to be negatively affected. Please build/run the ClusterD process using '-c release' configuration!") | ||
| #endif | ||
|
|
||
| try await daemon.system.park() |
There was a problem hiding this comment.
await is not needed, for now at least
| @@ -404,31 +404,65 @@ protocol ClusterSystemInstrumentationProvider { | |||
| /// all the nodes of an existing cluster. | |||
| public struct ServiceDiscoverySettings { | |||
| let implementation: ServiceDiscoveryImplementation | |||
| private let _initialize: (ClusterSystem) -> Void | |||
There was a problem hiding this comment.
A bit unclear naming, took some time to figure out, guess something more specific about cluster daemon, like _initializeClusterd. Wonder also if it should be optional and only set in init(clusterdEndpoint: Cluster.Endpoint), otherwise again—not very clear function.
| } | ||
|
|
||
| /// Locate the default `ClusterD` process and use it for discovering cluster nodes. | ||
| public static func clusterd(endpoint: Cluster.Endpoint?) -> Self { |
There was a problem hiding this comment.
That's neat, my initial impression was it's for local clustering, but guess we can define any endpoint.
| "MultiNodeTestKit", | ||
| .product(name: "ArgumentParser", package: "swift-argument-parser"), | ||
| ] | ||
| ), | ||
|
|
||
| .executableTarget( | ||
| name: "Clusterd", |
There was a problem hiding this comment.
Let's rename to swift-clusterd now? Or at least lowercased clusterd would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PoC how a
clusterddaemon could look like.Usage in practice would be to just ensure we start the daemon OR if ANY of the nodes is using daemon discovery make sure one of them spawns it or something like that.
This way nodes can join without hardcoding discovery of peer nodes when playing around locally.
This is inspired by https://forums.swift.org/t/beginner-advice-for-distributed-distributedcluster-modules/72391/11 and erlang's shortnames + https://www.erlang.org/docs/25/man/epmd
Creating a few nodes in a system would literarily be:
this basically just does:
This is the same as epmd, it has to be running somewhere.
And applications just do:
and you're done:
they'll join eachother.
Follow up here:
ClusterDshould be a "HIDDEN" member in the membershipswift-clusterd(the cluster daemon for the swift distributed cluster)resolves #1152