Make memset_s consistent with Darwin.
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Lukasa
reviewed
Oct 6, 2020
Resolves [issue#51](apple#51). In Swift 5.3, a warning is viewed on Linux because `memset_s` implemented in this module returns `Void`. This commit let the function return the same type with Darwin.
Lukasa
approved these changes
Oct 6, 2020
|
@swift-server-bot test this please |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue#51.
In Swift 5.3, a warning is viewed on Linux because
memset_simplemented in this module returnsVoid.This PR let the function return the same type with Darwin.
Checklist
Result:
No warnings are viewed while building.