Update to Developer Beta 3 build. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The API failure note is irrelevant: we have not shipped the error that is being removed in this patch. |
glbrntt
reviewed
Jul 23, 2020
| #if (os(macOS) || os(iOS) || os(watchOS) || os(tvOS)) && CRYPTO_IN_SWIFTPM && !CRYPTO_IN_SWIFTPM_FORCE_BUILD_API | ||
| @_exported import CryptoKit | ||
| #else | ||
| import Foundation |
There was a problem hiding this comment.
What's being used from Foundation here?
There was a problem hiding this comment.
Nothing, but this is a pretty ordinary starting stanza and I'm loathe to change it. 😉
|
|
||
| let sig = ASN1.ECDSASignature(r: r, s: s) | ||
| var serializer = ASN1.Serializer() | ||
| try! serializer.serialize(sig) |
There was a problem hiding this comment.
The ! is ok for two reasons:
- This is a
var, so we can't throw even if we wanted to: crashing is our only accessible error handling mode - This is not being computed over arbitrary data but previously-validated data, so it should not be possible for this to fail. If it did, it would be our error.
glbrntt
approved these changes
Jul 24, 2020
FredericJacobs
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.