Update BoringSSL to 53a17f55247101105ae35767d5c5a6c311843a8e #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Jun 1, 2020
| @@ -188,7 +188,7 @@ PATTERNS=( | |||
| 'crypto/*/*/*.S' | |||
| 'crypto/*/*/*/*.c' | |||
| 'third_party/fiat/*.h' | |||
| 'third_party/fiat/*.c' | |||
| #'third_party/fiat/*.c' | |||
There was a problem hiding this comment.
is this commented rather than deleted deliberately?
There was a problem hiding this comment.
Yes: the presence of C files in this directory changes over time, and I got sick of deleting and re-adding this line all the time, so I just commented it out.
weissi
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the vendoring script to handle the slightly changed layout of BoringSSL and removed the workaround for Folly's weak linking dance as it's no longer needed.