Update BoringSSL to 6a2ccdcc2ed1d37a43a2183658d2ae61fd5ce208 #255
Conversation
|
|
||
| if(CMAKE_SYSTEM_NAME STREQUAL Darwin AND CMAKE_SYSTEM_PROCESSOR MATCHES "amd64|x86_64") | ||
| target_sources(CCryptoBoringSSL PRIVATE | ||
| crypto/chacha/chacha-x86_64-mac.mac.x86_64.S |
There was a problem hiding this comment.
What happened to all of the asm? And is this big if needed anymore?
There was a problem hiding this comment.
Good catch. It's still there, but I suspect the script is looking in the wrong place.
There was a problem hiding this comment.
Ah yeah, so these are now generated by BoringSSL, and it expects the names to match.
There was a problem hiding this comment.
OOI what happens if they are missing? Presumably there's a lower-perf fallback?
There was a problem hiding this comment.
No, I think the compile would fail. You need NO_ASM set to fallback. We don't build the cmake version in CI here which is why we didn't notice.
There was a problem hiding this comment.
There is a cmake CI job which did pass:
https://ci.swiftserver.group/job/swift-crypto-cmake-prb/306/
It builds the project with ninja:
swift-crypto/docker/docker-compose.yaml
Line 37 in 81bee98
and it looks like we only set NO_ASM when building was WASI:
Line 104 in 81bee98
This is a little surprising given the above...
There was a problem hiding this comment.
Yeah, that's very curious.
Lukasa
force-pushed
the
cb-update-boringssl-20240903
branch
from
8841cb1
to
08ee77f
Compare
There have been a few changes in the BoringSSL build, so those are present in this commit too. Otherwise, this updates BoringSSL to 6a2ccdcc2ed1d37a43a2183658d2ae61fd5ce208.