Make Curve25519 PublicKey
s conform to Equatable
#173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Curve25519 PublicKeys conform to
Equatable
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
When PublicKey's are used in
struct
's that are markedEquatable
those structs cannot be auto-synthetized conform toEquatable
since these PublicKeys before this PR do not conform toEquatable
. This is rather annoying. And during the 5 years I've been working in the crypto industry I have added my own conformance to CryptoKit's PublicKeys to beEquatable
probably more than 10 times!There exists no security risk in making PublicKeys conform to
Equatable
, the current implementation does not usesafeCompare
, it could, but I deem it not necessary.There is really no drawback in adding
Equatable
conformance.Modifications:
Curve25519.Signing.PublicKey
beEquatable
Curve25519.KeyAgreement.PublicKey
beEquatable
Result:
Curve25519.Signing.PublicKey
andCurve25519.KeyAgreement.PublicKey
now conform toEquatable
.