-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[concurrency] conform Deque.Iterator to unchecked-Sendable #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
lorentey
reviewed
Aug 20, 2024
glessard
force-pushed
the
rdar134300306
branch
from
August 20, 2024 00:50
5a1457f
to
ff11253
Compare
@swift-ci please test |
glessard
force-pushed
the
rdar134300306
branch
from
August 20, 2024 01:02
ff11253
to
f83b5d7
Compare
glessard
force-pushed
the
rdar134300306
branch
from
August 20, 2024 01:03
f83b5d7
to
73f45ac
Compare
glessard
changed the title
[concurrency] conform Deque._Storage to Sendable
[concurrency] conform Deque.Iterator to unchecked-Sendable
Aug 20, 2024
lorentey
approved these changes
Aug 20, 2024
@swift-ci please test |
lorentey
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source file removal needs to be reflected in CMakeLists.txt and Xcode/Collections.xcodeproj
lorentey
approved these changes
Aug 20, 2024
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a toolchain that contains swiftlang/swift#75782 (79bf5d51ca4b55afdb29102f411898d78cbe0bf2),
Deque
no longer compiles in Swift 6 mode.extension Deque._Storage: @unchecked Sendable {}
makes it compile, though it may not be the best solution?Addresses rdar://134300306
Checklist