Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concurrency] conform Deque.Iterator to unchecked-Sendable #414

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Aug 19, 2024

On a toolchain that contains swiftlang/swift#75782 (79bf5d51ca4b55afdb29102f411898d78cbe0bf2), Deque no longer compiles in Swift 6 mode.

extension Deque._Storage: @unchecked Sendable {} makes it compile, though it may not be the best solution?

Addresses rdar://134300306

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@glessard glessard requested a review from lorentey as a code owner August 19, 2024 23:37
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard
Copy link
Contributor Author

@swift-ci please test

@lorentey lorentey added this to the 1.1.3 milestone Aug 20, 2024
@glessard glessard changed the title [concurrency] conform Deque._Storage to Sendable [concurrency] conform Deque.Iterator to unchecked-Sendable Aug 20, 2024
@glessard
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file removal needs to be reflected in CMakeLists.txt and Xcode/Collections.xcodeproj

@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard merged commit 9bf03ff into apple:release/1.1 Aug 20, 2024
1 of 2 checks passed
@glessard glessard deleted the rdar134300306 branch August 20, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants