Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos: OrderedSet Documentation #322

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix typos: OrderedSet Documentation #322

merged 2 commits into from
Nov 15, 2023

Conversation

kati-kms
Copy link
Contributor

@kati-kms kati-kms commented Oct 25, 2023 •
edited by lorentey
Loading

This PR contains a small fix for a typo in OrderedSet Documentation

I found this typo while testing the OrdedSet Documentation - Set Operations

before

After fix:

after

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

rdar://118429565

@kati-kms kati-kms requested a review from lorentey as a code owner October 25, 2023 15:47
@kati-kms kati-kms changed the title Fix typos: OrderedSet.md Documentation Fix typos: OrderedSet Documentation Oct 25, 2023
lorentey
lorentey approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- thank you very much for taking the effort to fix it! 👍

@lorentey
Copy link
Member

lorentey commented Nov 9, 2023

@kati-kms Would you mind rebasing this PR on the release/1.0 branch?

I think it would make sense to ship it as part of swift-collections 1.0.6.

(If not, we can still land this; I'll just cherry pick it there myself.)

@lorentey lorentey added this to the 1.0.6 milestone Nov 9, 2023
@lorentey lorentey self-assigned this Nov 9, 2023
@lorentey
Copy link
Member

lorentey commented Nov 9, 2023

@swift-ci test

@kati-kms kati-kms changed the base branch from main to release/1.0 November 10, 2023 06:06
@kati-kms kati-kms changed the base branch from release/1.0 to main November 10, 2023 06:07
@kati-kms kati-kms changed the base branch from main to release/1.0 November 10, 2023 06:57
@kati-kms
Copy link
Contributor Author

@lorentey
I've done rebasing this PR on the release/1.0 branch, so please check it!

@lorentey
Copy link
Member

Nice! Thank you 👍

@lorentey
Copy link
Member

@swift-ci test

@lorentey
Copy link
Member

The macOS failure is sadly expected, it's not related to this PR.

@lorentey lorentey merged commit e8699cc into apple:release/1.0 Nov 15, 2023
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Dec 21, 2023
@cgrindel-self-hosted-renovate
chore(deps): update dependency com_github_apple_swift_collections to …
c56a21c 
…v1.0.6 (#822)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[com_github_apple_swift_collections](https://togithub.com/apple/swift-collections)
| http_archive | patch | `1.0.5` -> `1.0.6` |

---

### Release Notes

<details>
<summary>apple/swift-collections
(com_github_apple_swift_collections)</summary>

###
[`v1.0.6`](https://togithub.com/apple/swift-collections/releases/tag/1.0.6):
Swift Collections 1.0.6

[Compare
Source](https://togithub.com/apple/swift-collections/compare/1.0.5...1.0.6)

This bugfix release adds `Sendable` conformances to all public types
(fixing compatibility with Swift's strict concurrency checking), and
speeds up equality checks (`==`) of identical collection values.

##### What's Changed

- Fix typos: OrderedSet Documentation by
[@&#8203;kati-kms](https://togithub.com/kati-kms) in
[https://github.com/apple/swift-collections/pull/322](https://togithub.com/apple/swift-collections/pull/322)
- \[1.0] build: support building in Debug mode on Windows by
[@&#8203;compnerd](https://togithub.com/compnerd) in
[https://github.com/apple/swift-collections/pull/337](https://togithub.com/apple/swift-collections/pull/337)
- build: tweak search path for embedding by
[@&#8203;compnerd](https://togithub.com/compnerd) in
[https://github.com/apple/swift-collections/pull/338](https://togithub.com/apple/swift-collections/pull/338)
- \[OrderedDictionary] forward ordered dictionary values equality to
values property by [@&#8203;vanvoorden](https://togithub.com/vanvoorden)
in
[https://github.com/apple/swift-collections/pull/335](https://togithub.com/apple/swift-collections/pull/335)
- \[OrderedSet] forward ordered set equality to elements property by
[@&#8203;vanvoorden](https://togithub.com/vanvoorden) in
[https://github.com/apple/swift-collections/pull/340](https://togithub.com/apple/swift-collections/pull/340)
- \[Deque] check deque equality with buffer identity by
[@&#8203;vanvoorden](https://togithub.com/vanvoorden) in
[https://github.com/apple/swift-collections/pull/341](https://togithub.com/apple/swift-collections/pull/341)
- \[OrderedDictionary] Fix usage of deprecated API in index(forKey:)
docs by [@&#8203;lorentey](https://togithub.com/lorentey) in
[https://github.com/apple/swift-collections/pull/342](https://togithub.com/apple/swift-collections/pull/342)
- \[1.0] Backport Sendable conformances on all public types by
[@&#8203;lorentey](https://togithub.com/lorentey) in
[https://github.com/apple/swift-collections/pull/343](https://togithub.com/apple/swift-collections/pull/343)
- OrderedSet: Fix sendable conformance on old swifts by
[@&#8203;lorentey](https://togithub.com/lorentey) in
[https://github.com/apple/swift-collections/pull/346](https://togithub.com/apple/swift-collections/pull/346)
- Update CMake configuration by
[@&#8203;lorentey](https://togithub.com/lorentey) in
[https://github.com/apple/swift-collections/pull/347](https://togithub.com/apple/swift-collections/pull/347)

##### New Contributors

- [@&#8203;kati-kms](https://togithub.com/kati-kms) made their first
contribution in
[https://github.com/apple/swift-collections/pull/322](https://togithub.com/apple/swift-collections/pull/322)
- [@&#8203;vanvoorden](https://togithub.com/vanvoorden) made their first
contribution in
[https://github.com/apple/swift-collections/pull/335](https://togithub.com/apple/swift-collections/pull/335)

**Full Changelog**:
apple/swift-collections@1.0.5...1.0.6

Thank you to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees

@lorentey lorentey

Labels
None yet
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@kati-kms @lorentey