Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OrderedDictionary] Fix type inference issue with OrderedDictionary.init(grouping:by:) #140

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[OrderedDictionary] Fix type inference issue with OrderedDictionary.init(grouping:by:) #140

merged 1 commit into from
Feb 9, 2022

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Feb 8, 2022

This adds a new overload to help the type checker infer [S.Element] as the default Value type.

Resolves #139.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey
[OrderedDictionary] Fix type inference issue with `OrderedDictionary.…
50e6a1a 
…init(grouping:by:)`

This adds a new overload to help the type checker infer `[S.Element]` as the default `Value` type.

Resolves #139.
@lorentey lorentey requested a review from natecook1000 February 8, 2022 22:17
@lorentey
Copy link
Member Author

lorentey commented Feb 8, 2022

@swift-ci test

@lorentey lorentey linked an issue Feb 8, 2022 that may be closed by this pull request
Inference issue with OrderedDictionary.init(grouping:by:) #139
Closed
@lorentey lorentey merged commit 20e7fce into release/1.0 Feb 9, 2022
@lorentey lorentey deleted the fix-OrderedDictionary-grouping-inference branch February 9, 2022 19:55
@lorentey lorentey added this to the 1.0.3 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 Awaiting requested review from natecook1000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Inference issue with OrderedDictionary.init(grouping:by:)
1 participant
@lorentey