Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up cleanup of GitHub Actions migration #104

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Nov 18, 2024

Motivation:

Make use of more common GitHub Actions migration workflows and repository style changes.

Modifications:

  • Unit tests workflows make use of the NIO unit-tests workflow with additional checks enabled
  • Introduce main.yml which runs workflows on each commit to main and periodically to catch any regressions in merges or from upstream.
  • Enable nightly CI runs as a signal for upcoming failures as is done in other Swift on Server ecosystem repositories.
  • Remove the docker files which are no longer used and contained outdated pipelines.
  • Bring the Samples up to Swift 5.9 and add a CI pipeline to ensure their continued ability to compile.
  • Add Cxx interoperability checks
  • Enable API-breakage checks

Result:

More in common with other GitHub Actions adoptions, compiling Samples.

@rnro rnro force-pushed the github_actions_cleanup branch from daee1cf to cdb8e79 Compare November 18, 2024 16:12
**Motivation:**

Make use of more common GitHub Actions migration workflows and
repository style changes.

**Modifications:**

* Unit tests workflows make use of the NIO `unit-tests` workflow with
  additional checks enabled
* Introduce `main.yml` which runs workflows on each commit to `main` and
  periodically to catch any regressions in merges or from upstream.
* Enable nightly CI runs as a signal for upcoming failures as is done in
  other Swift on Server ecosystem repositories.
* Remove the docker files which are no longer used and contained
  outdated pipelines.
* Bring the Samples up to Swift 5.9 and add a CI pipeline to ensure
  their continued ability to compile.

**Result:**

More in common with other GitHub Actions adoptions, compiling Samples.
@rnro rnro force-pushed the github_actions_cleanup branch from cdb8e79 to 7a04c41 Compare November 18, 2024 16:14
@rnro rnro added the 🔨 semver/patch No public API change. label Nov 19, 2024
@rnro rnro merged commit 1e75872 into apple:main Nov 22, 2024
34 of 35 checks passed
@rnro rnro deleted the github_actions_cleanup branch November 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants