Stop using org.pkl-lang:pkl-cli-java, use org.pkl-lang:pkl-tools instead
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead `org.pkl-lang:pkl-tools` already bundles the same Pkl CLI `Main` class, so the additional `org.pkl-lang:pkl-cli-java` is unnecessary. `pkl-cli-java` shell front matter --------------------------------- The `pkl-cli-java` jar is prefixed with a small amount of shell front matter to allow it to both be used as a dependency and as an executable if the correct execution bit is set. This can possibly cause problems with some tooling, so removing it is preferred. The front matter: ``` ❯ curl -L -o jpkl 'https://repo1.maven.org/maven2/org/pkl-lang/pkl-cli-java/0.26.1/pkl-cli-java-0.26.1.jar' ❯ head -n 2 jpkl #!/bin/sh exec java -jar $0 "$@" ``` See: https://pkl-lang.org/main/current/pkl-cli/index.html#java-executable
sitaktif
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.pkl-lang:pkl-toolsalready bundles the same Pkl CLIMainclass, so the additionalorg.pkl-lang:pkl-cli-javais unnecessary.pkl-cli-javashell front matterThe
pkl-cli-javajar is prefixed with a small amount of shell front matter to allow it to both be used as a dependency and as an executable if the correct execution bit is set.This can possibly cause problems with some tooling, so removing it is preferred. The front matter:
See: https://pkl-lang.org/main/current/pkl-cli/index.html#java-executable