Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com #411

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Update github.com #411

merged 1 commit into from
Jan 19, 2021

Conversation

parkerbxyz
Copy link
Contributor

Updates and simplifies the password rules for github.com.

Disclaimer: I work for GitHub.

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

@rmondello
Copy link
Contributor

rmondello commented Jan 15, 2021

Disclaimer: I work for GitHub.

Thanks for that!

Are you interested in applying the rule to text fields themselves using the passwordRules attribute, such that GitHub itself “owns" the policy?

The README of this project says:

If a website changes its password requirements to be general enough to not warrant quirks, or if it adopts the passwordRules attribute to accurately communicate its requirements to password managers and web browsers, it should be removed from this list.

@parkerbxyz
Copy link
Contributor Author

Ah! I missed that in the README; thanks for bringing it to my attention. I do think that would be a better approach. I’ll take a crack at it.

Would you like to merge this in the meantime or would you rather wait? I’d be happy to open a new PR to remove github.com from this list once the rules are applied directly to the text fields.

@rmondello rmondello merged commit 5c63a5a into apple:main Jan 19, 2021
@rmondello
Copy link
Contributor

Merged. @parkerbxyz, please do come back once github.com is updated. :-)

@parkerbxyz parkerbxyz deleted the github.com branch June 17, 2021 23:33
@parkerbxyz parkerbxyz mentioned this pull request Jul 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants