Fix baddbmm handling of "beta" special-case #1801
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baddbmm()
has abeta
coefficient, by which bias may be multiplied.in the special-case where
beta=0
: bias may be ignored (confirmed by docs):we use this in diffusers / stable-diffusion to avoid adding attention bias when none is specified:
https://github.com/huggingface/diffusers/blob/bbab8553224d12f7fd58b0e65b0daf899769ef0b/src/diffusers/models/cross_attention.py#L237
currently, the special-case is determined by a comparison with
1.0
rather than0.0
. it looks like it was copied fromalpha
's special-case:coremltools/coremltools/converters/mil/frontend/torch/ops.py
Lines 5274 to 5282 in fa190de
changing this, fixed compilation of diffusers' UNetCondition2D model for me (which employs that baddbmm in CrossAttnProcessor).