Conv1D supports paddings. #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conv1D is designed for processing sequence data, so it is natural to handle paddings as part of its functionality. Thus, it introduces Conv1DWithPadding.
|
@ruomingp could you review? from 913 |
ruomingp
approved these changes
Nov 19, 2024
qdavid1
pushed a commit
to qdavid1/axlearn
that referenced
this pull request
Dec 11, 2024
Conv1D is designed for processing sequence data, so it is natural to handle paddings as part of its functionality. Thus, it introduces Conv1DWithPadding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conv1D is designed for processing sequence data, so it is natural to handle paddings as part of its functionality.
Thus, it introduces Conv1DWithPadding.