Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set retry flag to true by default for OkHttpFactory #928

Merged
merged 6 commits into from
Jun 6, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

It looks like setting okhttp client to not retry on connection failure by default causes issues while switching contexts (which was previously not the case with apache http client). This PR tries to enforce the default setting to true, but this still requires more testing in the client side, because the problem is not always reproducible.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@iddol
Copy link

iddol commented Jun 2, 2018

It would be helpful to make the other private setters and getters (e.g., setResponseCodec(), setCommandCodec() protected as well) - see issue #920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants