-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update touch ID enroll method #695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
*/ | ||
@Deprecated | ||
default void toggleTouchIDEnrollment() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach We haven't released a version after this implementation. Can we remove this or Do you still wanted it to be marked deprecated
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking it as deprecated is safer. We can remove as soon as beta is released (what we, actually, always do)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach It looks fine. I want to run the test, merge this PR if everything is ok and publish it in 5.0.0 on this (26.08.2017-27.08.2017) weekend.
@KazuCocoa FYI |
Change list
Now it is possible to set the desired state for Touch ID Enrolment feature.
Types of changes
Details
the PR is based on appium/appium-xcuitest-driver#506