The addition to #442 #465
Merged
The addition to #442 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version updates Changes as per latest pom.xml Added pom.xml and updated eclipse compiler dependency
…/java-client into SrinivasanTarget-gradlemigration
- gradle.build was improved. - the migration to java 8 has been started - AOP tools for the listening to events were synchronized with actual project state - pom.xml was moved to the `archive` directory. This file may be helpful for some time.
|
@TikhomirovSergey Overall LGTM 👍 One minor change Does Also codacy may not work properly now since PR has a merge commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
gradle.buildwas improved.project state
pom.xmlwas moved to thearchivedirectory. This file may be helpfulfor some time.
Types of changes
What types of changes are you proposing/introducing to Java client?