Use weaker interface HasIdentity instead of class RemoteWebElement #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
Details
In java_client code,
WebElement
parameter is casted toRemoteWebElement
.It makes hard to create proxy object for
WebElement
(like Selenide and probably some other frameworks do).Actually only method
getId()
is used. This method is declared in interfaceHasIdentity
.This pull request changes few places where
WebElement
is casted toRemoteWebElement
so that it's not casted toHasIdentity
instead ofRemoteWebElement
.Old code:
new code: