Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Scroll issue in flutter integration driver #2225

Closed
wants to merge 2 commits into from
Closed

fix: Scroll issue in flutter integration driver #2225

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678c933
Fix flutter scroll issue
Aug 28, 2024
396122b
Add test with scroll parameters
Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@Setter
public class ScrollParameter extends FlutterCommandParameter {
private AppiumBy.FlutterBy scrollTo;
private WebElement scrollView;
private AppiumBy.FlutterBy scrollView;
private ScrollDirection scrollDirection;
private Integer delta;
private Integer maxScrolls;
Expand Down Expand Up @@ -56,13 +56,13 @@ public Map<String, Object> toJson() {

params.put("finder", parseFlutterLocator(scrollTo));
Optional.ofNullable(scrollView)
.ifPresent(scrollView -> params.put("scrollView", scrollView));
.ifPresent(scrollView -> params.put("scrollView", parseFlutterLocator(scrollView)));
Optional.ofNullable(delta)
.ifPresent(delta -> params.put("delta", delta));
Optional.ofNullable(maxScrolls)
.ifPresent(maxScrolls -> params.put("delta", maxScrolls));
.ifPresent(maxScrolls -> params.put("maxScrolls", maxScrolls));
mykola-mokhnach marked this conversation as resolved.
Show resolved Hide resolved
Optional.ofNullable(settleBetweenScrollsTimeout)
.ifPresent(timeout -> params.put("delta", settleBetweenScrollsTimeout));
.ifPresent(timeout -> params.put("settleBetweenScrollsTimeout", settleBetweenScrollsTimeout));
Optional.ofNullable(scrollDirection)
.ifPresent(direction -> params.put("scrollDirection", direction.getDirection()));
Optional.ofNullable(dragDuration)
Expand Down
Loading