feat: Add support for FlutterIOSDriver #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Outdated
Show resolved
Hide resolved
|
@sudharsan-selvaraj Can you please |
src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
Outdated
Show resolved
Hide resolved
sudharsan-selvaraj
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
src/main/java/io/appium/java_client/flutter/FlutterDriverOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/options/SupportsFlutterSystemPortOption.java
Outdated
Show resolved
Hide resolved
|
It looks like integration tests need some attention |
valfirst
requested changes
Jul 23, 2024
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/DoubleClickParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
Outdated
Show resolved
Hide resolved
|
Please make sure WDA is prebuilt and simulator is started before flutter iOS tests are executed |
Sure, I just used some changes to prevent test from uninstalling the app for every tests. But currently the ci is failing way early during build when trying to fetch selenium version from https://oss.sonatype.org/content/repositories/snapshots/org/seleniumhq/selenium/selenium-api/ I'll will keep an eye on the execution and update the tests if needed. |
|
CI is finally happy:) |
mykola-mokhnach
approved these changes
Jul 23, 2024
valfirst
approved these changes
Jul 23, 2024
KazuCocoa
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
1.The change Introduces FlutterIOSDriver class implementing remaining Flutter commands.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub