Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Code style issues to match Java standards #2017

Merged
merged 15 commits into from
Sep 23, 2023

Conversation

ashwithpoojary98
Copy link
Contributor

@ashwithpoojary98 ashwithpoojary98 commented Sep 17, 2023

Change list

  • Added HTML tags to doc links
  • Added a private constructor to restrict the creation of new objects of the class
  • Removed extra parentheses from lambda expressions
  • Renamed class and method variables to be more descriptive
  • Added override annotations to methods that override the parent class

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

To meet Java code standards, I made a few changes to method and class-level variables:
Added a Lombok no-arg constructor with private access to restrict the user from creating a new object of the class, since this class consists of all static methods.
Added override annotations to improve the readability of methods and removed additional code from lambda expressions.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@mykola-mokhnach
Copy link
Contributor

Thank you @ashwithpoojary98
Please rename the PR to follow https://www.conventionalcommits.org/en/v1.0.0/
Also please make sure you have signed the CLA

@ashwithpoojary98 ashwithpoojary98 changed the title Java code conventions fixes Fix Code style issues to match Java standards Sep 18, 2023
@ashwithpoojary98
Copy link
Contributor Author

ashwithpoojary98 commented Sep 18, 2023

@mykola-mokhnach Thanks for reviewing the PR. I updated the code as per your comments. Please review.

@ashwithpoojary98 ashwithpoojary98 changed the title Fix Code style issues to match Java standards fix:Fix Code style issues to match Java standards Sep 18, 2023
@ashwithpoojary98 ashwithpoojary98 changed the title fix:Fix Code style issues to match Java standards fix: Fix Code style issues to match Java standards Sep 18, 2023
@ashwithpoojary98
Copy link
Contributor Author

updated the workflow issue

@ashwithpoojary98
Copy link
Contributor Author

Updated workflow issue

@ashwithpoojary98
Copy link
Contributor Author

ashwithpoojary98 commented Sep 21, 2023

The Boolean check type casting issue was reverted.

@ashwithpoojary98
Copy link
Contributor Author

All checks have passed!!

@mykola-mokhnach mykola-mokhnach merged commit 01b9e16 into appium:master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants