-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Code style issues to match Java standards #2017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwithpoojary98
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
September 17, 2023 16:01
src/main/java/io/appium/java_client/imagecomparison/ComparisonResult.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/pagefactory/interceptors/InterceptorOfAListOfElements.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/options/SystemScript.java
Outdated
Show resolved
Hide resolved
Thank you @ashwithpoojary98 |
ashwithpoojary98
changed the title
Java code conventions fixes
Fix Code style issues to match Java standards
Sep 18, 2023
@mykola-mokhnach Thanks for reviewing the PR. I updated the code as per your comments. Please review. |
src/main/java/io/appium/java_client/remote/options/SystemScript.java
Outdated
Show resolved
Hide resolved
ashwithpoojary98
changed the title
Fix Code style issues to match Java standards
fix:Fix Code style issues to match Java standards
Sep 18, 2023
ashwithpoojary98
changed the title
fix:Fix Code style issues to match Java standards
fix: Fix Code style issues to match Java standards
Sep 18, 2023
updated the workflow issue |
mykola-mokhnach
approved these changes
Sep 18, 2023
Updated workflow issue |
valfirst
requested changes
Sep 20, 2023
src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/pagefactory/bys/builder/AppiumByBuilder.java
Outdated
Show resolved
Hide resolved
…piumByBuilder.java Co-authored-by: Valery Yatsynovich <[email protected]>
…piumByBuilder.java Co-authored-by: Valery Yatsynovich <[email protected]>
SrinivasanTarget
approved these changes
Sep 20, 2023
The Boolean check type casting issue was reverted. |
valfirst
approved these changes
Sep 21, 2023
All checks have passed!! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
To meet Java code standards, I made a few changes to method and class-level variables:
Added a Lombok no-arg constructor with private access to restrict the user from creating a new object of the class, since this class consists of all static methods.
Added override annotations to improve the readability of methods and removed additional code from lambda expressions.