Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementation of Chromium driver plus capabilities #2003

Merged
merged 8 commits into from
Sep 8, 2023
Merged

feat: Implementation of Chromium driver plus capabilities #2003

merged 8 commits into from
Sep 8, 2023

Conversation

AlessandroMiccoli
Copy link
Contributor

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

The following are implemented:

  • Chromium Driver implementation
  • Chromium Options implementation, plus appium capabilities of appium-chromium-driver)

@AlessandroMiccoli AlessandroMiccoli mentioned this pull request Sep 5, 2023
Closed
@AlessandroMiccoli AlessandroMiccoli changed the title Feature/issue 1995 feat: Implementation of Chromium driver plus capabilities Sep 5, 2023
@mykola-mokhnach
Copy link
Contributor

It looks like linter is not very happy. Please check the job results above

@valfirst valfirst linked an issue Sep 5, 2023 that may be closed by this pull request
[Feat]: implement Chromium driver and options #1995
Closed
@mykola-mokhnach
Copy link
Contributor

Please rebase with master. I have fixed several tests that were failing before

@AlessandroMiccoli
Copy link
Contributor Author

I made the changes. Please, could you answer the question here: ISSUE_1995? I am not sure if I need to add the goog options

@mykola-mokhnach
Copy link
Contributor

I made the changes. Please, could you answer the question here: ISSUE_1995? I am not sure if I need to add the goog options

replied

@mykola-mokhnach mykola-mokhnach merged commit 923806a into appium:master Sep 8, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@saikrishna321 saikrishna321 Awaiting requested review from saikrishna321 saikrishna321 is a code owner

@valfirst valfirst Awaiting requested review from valfirst valfirst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: implement Chromium driver and options
3 participants
@AlessandroMiccoli @mykola-mokhnach @SrinivasanTarget