Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate tapWithShortPressDuration cap #1825

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

rerorero
Copy link
Contributor

Change list

This PR removes tapWithShortPressDuration cap.
see appium/appium-xcuitest-driver#1481

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

see appium/appium-xcuitest-driver#1481

@rerorero rerorero marked this pull request as ready for review December 28, 2022 15:24
@mykola-mokhnach
Copy link
Contributor

Please mark it as deprecated first. Then we remove the constant in later releases

@rerorero
Copy link
Contributor Author

OK, marked it as deprecated.

@rerorero rerorero changed the title chore: remove tapWithShortPressDuration cap chore: deprecate tapWithShortPressDuration cap Dec 29, 2022
@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Dec 29, 2022

> /Users/runner/work/java-client/java-client/src/main/java/io/appium/java_client/remote/IOSMobileCapabilityType.java:174: error: unknown tag: Deprecated
> [36](https://github.com/appium/java-client/actions/runs/3797269944/jobs/6461608860#step:4:37)
>      * @Deprecated This capability is not being used.

Are you sure the tag name has been spelled correctly?

@rerorero
Copy link
Contributor Author

oops, sorry. fixed

@mykola-mokhnach mykola-mokhnach merged commit 99804d0 into appium:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants