Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Force unified imports order #1793

Merged

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Nov 4, 2022

Change list

Closes #1722:

  • Use unified imports order for all classes
  • Configure checkstyle rules for imports

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

The imports order reflects the default order from IntellJ IDEA (so that developers don't need to configure their IDEs) except for star-imports, they should be avoided.

@mykola-mokhnach
Copy link
Contributor

it would be cool we we could reference the original Google style from a remote repository and override it locally, but I assume it is not possible

@valfirst
Copy link
Collaborator Author

valfirst commented Nov 4, 2022

it would be cool we we could reference the original Google style from a remote repository and override it locally, but I assume it is not possible

yes, unfortunately that's not possible

@SrinivasanTarget SrinivasanTarget merged commit 83f2ac2 into appium:master Nov 4, 2022
@valfirst valfirst deleted the force-unified-imports-order branch November 4, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Styles not in sync
3 participants