-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add WDA-related XCUITestOptions #1552
chore: Add WDA-related XCUITestOptions #1552
Conversation
Optional.ofNullable(args).ifPresent((v) -> result.put("args", v)); | ||
Optional.ofNullable(env).ifPresent((v) -> result.put("env", v)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: parenthesis could be removed
Optional.ofNullable(args).ifPresent((v) -> result.put("args", v)); | |
Optional.ofNullable(env).ifPresent((v) -> result.put("env", v)); | |
Optional.ofNullable(args).ifPresent(v -> result.put("args", v)); | |
Optional.ofNullable(env).ifPresent(v -> result.put("env", v)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep them for better readability
.map((v) -> { | ||
try { | ||
return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | ||
} catch (MalformedURLException e) { | ||
throw new IllegalArgumentException(e); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor:
.map((v) -> { | |
try { | |
return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | |
} catch (MalformedURLException e) { | |
throw new IllegalArgumentException(e); | |
} | |
}); | |
.map(v -> { | |
try { | |
return v instanceof URL ? (URL) v : new URL(String.valueOf(v)); | |
} catch (MalformedURLException e) { | |
throw new IllegalArgumentException(e); | |
} | |
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
.map((v) -> { | ||
try { | ||
return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | ||
} catch (MalformedURLException e) { | ||
throw new IllegalArgumentException(e); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor:
.map((v) -> { | |
try { | |
return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | |
} catch (MalformedURLException e) { | |
throw new IllegalArgumentException(e); | |
} | |
}); | |
.map(v -> { | |
try { | |
return v instanceof URL ? (URL) v : new URL(String.valueOf(v)); | |
} catch (MalformedURLException e) { | |
throw new IllegalArgumentException(e); | |
} | |
}); |
} catch (MalformedURLException e) { | ||
throw new IllegalArgumentException(e); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to move the repeated logic to a new method CapabilityHelpers#toUrl(Object)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it does
String signingId = cert.getXcodeSigningId() == null | ||
? DEFAULT_XCODE_SIGNING_ID | ||
: cert.getXcodeSigningId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String signingId = cert.getXcodeSigningId() == null | |
? DEFAULT_XCODE_SIGNING_ID | |
: cert.getXcodeSigningId(); | |
String signingId = Optional.ofNullable(cert.getXcodeSigningId()).orElse(DEFAULT_XCODE_SIGNING_ID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
Change list
Added WDA-related XCUITestOptions
Types of changes