feat: Add support of extended Android geolocation #1492
Conversation
|
FYI @KazuCocoa @ki4070ma |
|
Any plans to release a new java-client with this functionality? |
|
@dr29bart will release to maven central tomorrow. You can till then still use latest commit through jitpack.io. |
| * @param longitude longitude value | ||
| * @param latitude latitude value | ||
| */ | ||
| public AndroidGeoLocation(double longitude, double latitude) { |
There was a problem hiding this comment.
@mykola-mokhnach does it make sense to match order of parameters with org.openqa.selenium.html5.Location
public Location(double latitude, double longitude, double altitude) {
this.latitude = latitude;
this.longitude = longitude;
this.altitude = altitude;
}
?
There was a problem hiding this comment.
I'm not sure this is needed as altitude is optional. And for optional args I'd prefer to use builder methods
There was a problem hiding this comment.
sorry, I meant order of latitude and then longitude parameters.
existing code in 7.5.1
driver.setLocation(new Location(gps.getLatitude(), gps.getLongitude(), 240));
new version will require parameters swap:
driver.setLocation(new AndroidGeoLocation(gps.getLongitude(), gps.getLatitude());
There was a problem hiding this comment.
I'd say it is easy to change this while it's not published yet. Let us know if you want to prepare a PR @dr29bart
Change list
Adds an API that allows to also provide
speedandsatellitesparameters for setGeolocation API on Android platformTypes of changes
Details
Based on appium/appium-adb#571