feat: Add ability to set multiple settings #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Nov 9, 2020
valfirst
force-pushed
the
add-ability-to-set-multiple-settings
branch
from
f5190d0
to
57a3b96
Compare
SrinivasanTarget
approved these changes
Nov 9, 2020
valfirst
force-pushed
the
add-ability-to-set-multiple-settings
branch
from
57a3b96
to
cb178f6
Compare
|
It looks like some e2e tests are not very stable. We need to check these later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Add ability to set multiple settings to avoid performance overhead when several changes are required to be done at once.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply