Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add executeDriverScript command #1165

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Add executeDriverScript command #1165

merged 5 commits into from
Jun 28, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Based on appium/appium-base-driver#328

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

KazuCocoa
KazuCocoa approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SrinivasanTarget
SrinivasanTarget reviewed Jun 28, 2019
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach Checkstyle isn't happy. Also good to have some tests with WDIO. Otherwise good to me.

@mykola-mokhnach mykola-mokhnach merged commit f8982af into appium:master Jun 28, 2019
@mykola-mokhnach mykola-mokhnach deleted the add_execute branch June 28, 2019 18:58
jlipps
jlipps reviewed Jun 28, 2019
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 @SrinivasanTarget what will it take to get a publish :-)

@takeyaqa takeyaqa mentioned this pull request Jul 8, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget left review comments

@jlipps jlipps jlipps left review comments

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykola-mokhnach @jlipps @KazuCocoa @SrinivasanTarget