Add apple tvOS platform constant #1142
Conversation
| extends AppiumDriver<T> | ||
| implements HidesKeyboardWithKeyName, HasIOSSettings, HasOnScreenKeyboard, | ||
| LocksDevice, FindsByIosNSPredicate<T>, FindsByIosClassChain<T>, | ||
| PushesFiles, CanRecordScreen, HasIOSClipboard { |
There was a problem hiding this comment.
Did you check all of commands work? (just a confirmation.)
Clipboad does not work on this list.
|
For me it does not make sense to have a separate class, which, actually, adds nothing. We already had youidriver like that and removed it. |
|
@mykola-mokhnach sounds good. Since AppiumDriver is not abstract, we can use that. Do you think, platform name |
Yes, this will be useful to have a constant for it |
ajeeshvl
changed the title
|
@mykola-mokhnach @KazuCocoa @SrinivasanTarget removed TVOSDriver class. |
| @@ -22,4 +22,5 @@ | |||
| String IOS = "iOS"; | |||
| String FIREFOX_OS = "FirefoxOS"; | |||
| String WINDOWS = "Windows"; | |||
| String TVOS = "tvOS"; | |||
There was a problem hiding this comment.
Does it make sense to have it inside AutomationName interface instead?
There was a problem hiding this comment.
No, I do not think so in this case.
It confuses users a bit since when we use tvOS, the capability should be like:
...
automationName: 'xcuites', # AutomationName.IOS_XCUI_TEST
platformName: 'tvOS' # AutomationName.IOS_TVOS vs MobilePlatform.TVOS (or APPLE_TVOS is proper?)
...
There was a problem hiding this comment.
Unlike youiengine tvos uses xcuitest as automation name. I still think having a TVOSdriver would also be helpful. That would avoid confusion for users around what capability needs to be used for tvos.
There was a problem hiding this comment.
I don't have a strong opinion about the new class.
I would respect @mykola-mokhnach, @saikrishna321 and @SrinivasanTarget
There was a problem hiding this comment.
I would say not to have TVOSDriver class. We should just document what capability to use for TVOS.
Change list
This is to add support for apple tvOS.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
This adds tvOS platform.
tvOS also uses xcuitest-driver.
Related PRs
appium/appium-xcuitest-driver#911
appium/appium#12401