Add endpoints for lock/unlock #595
Conversation
|
Waiting until WDA submodule is bumped in order to merge this change |
|
Have you rebased the WDA change so the tests can run? |
|
There is nothing to rebase yet. appium/WebDriverAgent#32 is not in the bundled WDA submodule |
|
But the tests aren't going to run on the WDA change (appium/WebDriverAgent#32) until it has been rebased with the WDA master, and repushed to Github. |
|
My point is that it is better to do WDA updates in a separate PR, so we can carefully check tests and fix the stuff before it breaks our regression |
|
Yes. I agree completely. My point is that the WDA code itself has tests, and they aren't getting run because Travis is broken. And they aren't getting run on CircleCI because they don't have the configuration code yet. That configuration code is in master of our WDA fork. So the PRs need to be rebased with that and repushed so builds on CircleCI get initiated. Without that, they will not get merged because we have no idea if they work. |
…uitest-driver into lock # Conflicts: # lib/commands/index.js
|
I'll recreate this PR. There are problems with submodule rebase |
Do not merge this PR until appium/WebDriverAgent#21 is in