-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove shrinkwrap #1985
chore: remove shrinkwrap #1985
Conversation
I am still in doubts regarding whether it makes sense to have |
Yes, understood. I like to not consider patch versions so much, but would like to lock minor/major for releases. |
I don't think I have a strong opinion anymore. The shrinkwrap-on-release strategy without package-lock has worked well in the past, but if you want to trial a change in this repo i think that's fine. |
we for sure need to have either shrinkwrap or package.lock both of them have their own pros and cons Until now the package.lock approach was ok'ish with automerge enabled and tests being green (after 10% failure threshold has been added ;) ) I would still prefer to get rid of package.lock though and only have shrinkwrap on release as such approach requires less maintenance. |
it seems like |
Ok, #2023 (comment) fixed the missing Lets close this since latest release includes |
Applied the same update to other drivers that did not have |
Noticed current uia2, xcuitest and probably other drivers also no longer include
npm-shrinkwrap.json
in the published packages.So maybe every install installs the latest dependencies in the package.json even when am installation command specifies an older version. (This is not good)
This repository already has lock file, so maybe we can remove
npm shrinkwrap
, then can expect the lock file will be part of npm install module to lock dependencies...? The npm command converts package-lock.json to npm-shrinkwrap.json so just removing it will keep package-lock.json I assume...If this works, we may be able to add package-lock.json file in each driver's top directory as same as this xcuitest to lock dependencies for each package versions
e.g.
5.0.0 no longer had. 4.32.0 still had, but 4.32.23 did not.
So I guess typescript update affected this...? Then, other drivers started recently???