Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try fix release to include npm-shrinkwrap.json #2023

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Conversation

KazuCocoa
Copy link
Member

not clear the reason since my local dry run had npm-shrinkwrap.json expectedly in the npm publish... and so far I cannot find the place that could remove npm-shrinkwrap.json unexpectedly....

Thus let me explicitly set npm-shrinkwrap.json in package.json how it will be...

@KazuCocoa KazuCocoa merged commit 57fc5b8 into master Sep 24, 2023
9 of 12 checks passed
@KazuCocoa KazuCocoa deleted the try-release-fix branch September 24, 2023 07:10
github-actions bot pushed a commit that referenced this pull request Sep 24, 2023
## [5.3.3](v5.3.2...v5.3.3) (2023-09-24)

### Bug Fixes

* try fix release to include npm-shrinkwrap.json ([#2023](#2023)) ([57fc5b8](57fc5b8)), closes [#2022](#2022)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa
Copy link
Member Author

Ok... so maybe we must explicitly set npm-shrinkwrap.json for now. This fixed that:

Screenshot 2023-09-24 at 12 16 52 AM

I'll add the same thing in other drivers that have npm shrinkwrap. I guess newer? npm or something changed the behavior?

anyway it is safe to set that explicitly as our release right now

@KazuCocoa
Copy link
Member Author

safari and gecko included everything, so their packages had no changes so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant