Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move WAD server installation into a driver script #277

Merged
merged 14 commits into from
Sep 16, 2024
Merged

feat: Move WAD server installation into a driver script #277

merged 14 commits into from
Sep 16, 2024

Conversation

mykola-mokhnach
Copy link

BREAKING CHANGE: WAD is does not get installed automatically anymore upon driver install

@mykola-mokhnach mykola-mokhnach changed the title feat: Move WAD server installation into a script feat: Move WAD server installation into a driver script Sep 14, 2024
@eglitise
Copy link

Great idea! Although, it seems like this can only install the .msi versions now, so not the latest 1.2.99. I think that should at least be added to the readme.
Out of curiosity, what happens if WAD is already installed - does it just replace the current version with the new one?
Also I don't recall how the semantic release bot worked, but should the PR title have feat!: instead? Or would the breaking change comment be enough?

@mykola-mokhnach
Copy link
Author

Also I don't recall how the semantic release bot worked, but should the PR title have feat!: instead? Or would the breaking change comment be enough?

It looks like the bot does not really understand exclamation marks in the title. It only pays attention to the presence of BREAKING CHANGE: magic in the commit message

@mykola-mokhnach
Copy link
Author

Although, it seems like this can only install the .msi versions now, so not the latest 1.2.99. I think that should at least be added to the readme.

Added support of 1.2.99

eglitise
eglitise reviewed Sep 14, 2024
View reviewed changes
scripts/install-wad.mjs Outdated Show resolved Hide resolved
KazuCocoa
KazuCocoa approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@KazuCocoa
Copy link
Member

@Dor-bl FYI (if you're interested in)

@mykola-mokhnach mykola-mokhnach merged commit 23ab085 into appium:master Sep 16, 2024
7 checks passed
@mykola-mokhnach mykola-mokhnach deleted the driver_inst branch September 16, 2024 06:12
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
87e1a1d 
## [3.0.0](v2.12.32...v3.0.0) (2024-09-16)

### ⚠ BREAKING CHANGES

* WAD is does not get installed automatically anymore upon driver install

From now on the driver install won't include the automatic server deployment. Instead it is expected that WAD server is installed via the driver script: `appium driver run windows install-wad <optional_wad_version>`.

### Features

* Move WAD server installation into a driver script ([#277](#277)) ([23ab085](23ab085))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mykola-mokhnach mykola-mokhnach mentioned this pull request Sep 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eglitise eglitise eglitise approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @eglitise @KazuCocoa