Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only restart system services if the language is actually changed #403

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

Related to appium/appium#19440

Perhaps, we need to add a separate capability to xcuitest driver as the next step to control this behaviour, so users could choose what is more important for them: running/cached WDA or fully translated UI dialogs.

cc @mwakizaka

@mykola-mokhnach
Copy link
Contributor Author

@mwakizaka Could you please help with testing of the PR?

lib/simulator-xcode-9.js Outdated Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach merged commit 62c2ffb into appium:master Nov 23, 2023
7 checks passed
@mykola-mokhnach mykola-mokhnach deleted the lang_check branch November 23, 2023 12:44
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
## [5.3.10](v5.3.9...v5.3.10) (2023-11-23)

### Bug Fixes

* Only restart system services if the language is actually changed ([#403](#403)) ([62c2ffb](62c2ffb))
Copy link

🎉 This PR is included in version 5.3.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants