Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getText enhancement for complex text widgets #755

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

tandt53
Copy link
Contributor

@tandt53 tandt53 commented Nov 30, 2024

hi there,

Recently I encountered a problem when getting text from Text widget. Then I tried to fix it by revise code in https://github.com/Alpaca00/command-driven-list, and it worked.

Thus, I decided to implement a new command getTextWithCommandExtension that is similar with dragAndDropWithCommandExtension. It works on my local.

Please refer to my flutter code here and attached video for my demo.

demo.mp4

Copy link

linux-foundation-easycla bot commented Nov 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

driver/lib/commands/execute.ts Outdated Show resolved Hide resolved
driver/lib/commands/execute.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@tandt53 tandt53 requested review from Alpaca00 and KazuCocoa December 2, 2024 02:24
@KazuCocoa KazuCocoa merged commit ab20371 into appium:main Dec 3, 2024
5 of 7 checks passed
@KazuCocoa
Copy link
Member

2.11.0 includes this PR.

@KazuCocoa KazuCocoa added the size:M contribution size: M label Jan 5, 2025
@jlipps
Copy link
Member

jlipps commented Jan 8, 2025

Hi @tandt53, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@tandt53
Copy link
Contributor Author

tandt53 commented Jan 9, 2025

Hi @tandt53, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

Thank you so much, @jlipps and @KazuCocoa! Contributing to Appium has been such an exciting journey, and I deeply appreciate this incredible gesture. Receiving this compensation as a New Year’s gift would make it even more special. My OpenCollective account name is tan do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M contribution size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants