Skip to content

Commit

Permalink
tune
Browse files Browse the repository at this point in the history
  • Loading branch information
KazuCocoa committed Jul 22, 2024
1 parent 1213aa0 commit dc15315
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 11 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/driver-function.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ jobs:
with:
api-level: ${{ env.API_LEVEL }}
arch: ${{ env.ARCH }}
script: ruby example_sample2.rb
script: |
cd example/ruby
ruby example_sample2.rb
target: google_apis
profile: Nexus 5X
disable-spellchecker: true
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ SKIP_IOS=1 appium driver doctor flutter
| Capability | Description | Example Values |
| - | - | -|
| appium:retryBackoffTime | The time wait for socket connection retry to get flutter session (default 3000ms)|500|
| appium:maxRetryCount | The count for socket connection retry for get flutter session (default 10) | 20|
| appium:observatoryWsUri | The URL to attach to the Dart VM. The Appium Flutter Driver finds the WebSocket URL from the device log by default. You can skip the finding the URL process by specifying this capability. Then, this driver attempt to establish a WebSocket connection against the given WebSocket URL. Note that this capability expects the URL is ready for access by outside an appium session. This flutter driver does not do port-forwarding with this capability. You may need to coordinate the port-forwarding as well. | 'ws://127.0.0.1:60992/aaaaaaaaaaa=/ws' |
| appium:isolateId | The isolate id to attach to as the initial attempt. A session can change the isolate with `flutter:setIsolateId` command. The default behavior finds `main` isolate id and attaches it. | `isolates/2978358234363215`, `2978358234363215` |
| appium:skipPortForward | Whether skip port forwarding from the flutter driver local to the device under test with `observatoryWsUri` capability. It helps you to manage the application under test, the observatory URL and the port forwarding configuration. The default is `true`. | true, false |
Expand Down Expand Up @@ -205,7 +203,6 @@ You have a couple of methods to start the application under test by establishing
1. Start a session without `app` capability
2. Install the application under test via `driver.install_app` or `mobile:installApp` command etc
3. Calls `flutter:connectObservatoryWsUrl` command to keep finding an observatory URL to the Dart VM
- `appium:retryBackoffTime` and `appium:maxRetryCount` will control the duration to keep finding an observatory URL to the Dart VM
4. (at the same time) Launch the application under test via outside the appium-flutter-driver
- e.g. Launch an iOS process via [ios-go](https://github.com/danielpaulus/go-ios), [iproxy](https://github.com/libimobiledevice/libusbmuxd#iproxy) or [tidevice](https://github.com/alibaba/taobao-iphone-device)
5. Once `flutter:connectObservatoryWsUrl` identify the observatory URL, the command will establish a connection to the Dart VM
Expand Down
4 changes: 4 additions & 0 deletions driver/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## not released
- Tune syslog scanning
- Drop `appium:maxRetryCount` and `appium:retryBackoffTime`

## 2.8.0
- Support `getWidgetDiagnostics`

Expand Down
6 changes: 0 additions & 6 deletions driver/lib/desired-caps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ export const desiredCapConstraints = {
avd: {
isString: true,
},
maxRetryCount: {
isNumber: true,
},
platformName: {
inclusionCaseInsensitive: [
'iOS',
Expand All @@ -16,9 +13,6 @@ export const desiredCapConstraints = {
isString: true,
presence: true,
},
retryBackoffTime: {
isNumber: true,
},
udid: {
isString: true,
},
Expand Down
3 changes: 2 additions & 1 deletion example/ruby/example_sample2_ios.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ class ExampleTests < Minitest::Test
automationName: 'flutter',
platformVersion: '17.4',
deviceName: 'iPhone 15 Plus',
app: "#{Dir.pwd}/../sample2/iOSFullScreen.zip"
app: "#{Dir.pwd}/../sample2/iOSFullScreen.zip",
showIOSLog: true
},
appium_lib: {
export_session: true,
Expand Down

0 comments on commit dc15315

Please sign in to comment.