feat: add useHIDClear capability and setting #952
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,10 @@ + (NSArray *)routes | |||
| [FBConfiguration forceSimulatorSoftwareKeyboardPresence]; | |||
| } | |||
|
|
|||
| if (capabilities[FB_CAP_USE_HID_CLEAR]) { | |||
There was a problem hiding this comment.
it is not really needed to add a capability for it. Settings could also be set upon session startup
| @@ -35,3 +35,4 @@ | |||
| NSString* const FB_SETTING_ANIMATION_COOL_OFF_TIMEOUT = @"animationCoolOffTimeout"; | |||
| NSString* const FB_SETTING_MAX_TYPING_FREQUENCY = @"maxTypingFrequency"; | |||
| NSString* const FB_SETTING_RESPECT_SYSTEM_ALERTS = @"respectSystemAlerts"; | |||
| NSString* const FB_SETTING_USE_HID_CLEAR = @"useHIDClear"; | |||
There was a problem hiding this comment.
how about changing the name to useClearTextShortcut ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: appium/appium#20727
Added
useHIDClearcapability and setting to be able to enable / disable text clear by HIDEvent.